-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Sort
input in Filters
#543
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 0ec6402 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📦 Next.js Bundle Analysis for @blobscan/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
283.66 KB (🟡 +38.04 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
New Page Added
The following page was added to the bundle from the code in this PR:
Page | Size (compressed) | First Load | % of Budget (350 KB ) |
---|---|---|---|
/block_neighbor |
251 B |
283.9 KB | 81.11% |
Eleven Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load | % of Budget (350 KB ) |
---|---|---|---|
/ |
352.46 KB |
636.12 KB | 181.75% (🟢 -4.82%) |
/address/[address] |
27.29 KB |
310.95 KB | 88.84% (🟢 -4.69%) |
/blob/[hash] |
27.33 KB |
310.98 KB | 88.85% (🟢 -4.31%) |
/blobs |
75.95 KB |
359.61 KB | 102.74% (🟡 +12.32%) |
/block/[id] |
14.01 KB |
297.67 KB | 85.05% (🟢 -4.25%) |
/blocks |
73.66 KB |
357.32 KB | 102.09% (🟡 +12.32%) |
/stats/blob |
336.49 KB |
620.15 KB | 177.18% (🟢 -4.79%) |
/stats/block |
337.64 KB |
621.29 KB | 177.51% (🟢 -4.76%) |
/stats/tx |
336.75 KB |
620.41 KB | 177.26% (🟢 -4.76%) |
/tx/[hash] |
15.07 KB |
298.72 KB | 85.35% (🟡 +0.52%) |
/txs |
73.14 KB |
356.8 KB | 101.94% (🟡 +10.30%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can simplify the design by doing something similar to the ThemeModeButton
: using a single icon wrapped in an IconButton
that toggles between BarsArrowDownIcon
and BarsArrowUpIcon
when clicked.
I would also have the desc sort set as default
Can we also add a changeset? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Done! It seems more simple and clear now 👍 |
The changeset script wasn't working. After fixing the config file (updating the base branch to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Checklist
Description
IconButtonGroup
component to be able to have a toggle between icons for the sorting typesFilters
component to choose to list the items inblocks
,blobs
andtransactions
table views inascending
ordescending
orderRelated Issue
Closes #435
Screenshots